We think that you should leave the shower switch on when not in use. If you feel more comfortable use it when you go away for a longer period of time like a holiday.
A loose connection in a shower pullcord switch is quite common, the internal connections can come loose over time and by pulling the cord every day it can increase the likelihood of this.